add structlog to dspace refactor #6
Conversation
| def main(ctx, url, email, password): | ||
| ctx.obj = {} | ||
| print('Application start') | ||
| structlog.configure(processors=[ |
There was a problem hiding this comment.
I was able to remove this entire block and it logged fine?
There was a problem hiding this comment.
Are you getting 2019-11-26 13:39.16 Application start or {"event": "Application start", "logger": "__main__", "level": "info", "timestamp": "2019-11-26T18:40:30.819933Z"}? I just commented it out again and I'm still having the same problem where it gives me unstructured log entries in the terminal but nothing to the file
ehanson8
force-pushed
the
add-structlog
branch
from
0a55c76 to
535e0ce
Compare
|
I would hold off on adding the config block. I am indeed seeing the unstructured message without it, but based on my understanding of structlog that seems wrong. We should take the time to understand what's going on before adding code just to make it work. |
|
OK, I'll pull it back |
|
And for the record, this is where I found the code that I'm adapting https://structlog.readthedocs.io/en/16.1.0/standard-library.html#suggested-configuration |
ehanson8
force-pushed
the
add-structlog
branch
2 times, most recently
from
b08c87b to
88ab8dd
Compare
ehanson8
force-pushed
the
add-structlog
branch
from
5ea8265 to
b43188f
Compare
|
Updated |
What does this PR do?
Adding structlog. For some reason, I had to add the config code block (lines 23-32) to get the desired output even though I didn't need to add that code block to my ArchivesSpace code. I did a lot of testing/comparison to no avail to but I may be adding a similar code block to the ArchivesSpace code in case there is some weird local thing that is triggering the structlog config in the ArchivesSpace repo.
Includes new or updated dependencies?
YES